Feature/night mode exceptions#2809
Open
euletheia wants to merge 4 commits into
Open
Conversation
euletheia
force-pushed
the
feature/night-mode-exceptions
branch
from
eca474c to
7a6dffa
Compare
Drawing heavily on hthienloc/DankMaterialShell@de3e8cf (excluded media players), give the possibility to specify a list of applications excluded from NightMode, alongside the ability to exclude fullscreen applications. (Logic is implemented on newly focused windows, and integrates with compositors overview mode so that NightMode is resumed on overview.) + Update GammaControlTab main section to use a SettingsCard component.
…ceptions - Use the appId matching function abstracted to Paths.qml. - Use common appId normalization functions to append/remove from settings list. - Align with GammaControlTab app list input fields to fix bug where white spaces only input would prevent field clearing on accept. - Align with GammaControlTab and use a Loader for AppBrowserPopup so that it can be recreated in case the popup is not closed with the dedicated button (i.e., via the compositor).
…ecreated if closed (Align with GammaControlTab changes)
euletheia
force-pushed
the
feature/night-mode-exceptions
branch
from
7a6dffa to
43a0917
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add night mode exceptions (fullscreen and custom app list).
Drawing heavily on hthienloc/DankMaterialShell@de3e8cf, give the possibility to specify a list of applications excluded from Night Mode, alongside the ability to exclude fullscreen applications.
Logic is implemented on newly focused windows, and integrates with compositors overview mode so that Night Mode is resumed on overview.1
Notes
MprisController:qml:20toPaths.qml:154with other (loosely-)related functions.Type of change
Related issues
Screenshots / video2
contrib_night-mode-exceptions.webm
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warningsFootnotes
This means that enabling fullscreen exclusion while fullscreen will do nothing because the implementation reacts to Toplevel change (application focus). ↩
Screen gamma change is obviously not visible in the video, but "it works on my machine". ↩